Conversation
… unfolding and alphaS; update wremnants-data with this file
davidwalter2
force-pushed
the
260116_updBinning
branch
from
101074d to
995126f
Compare
davidwalter2
force-pushed
the
260116_updBinning
branch
from
995126f to
c6c2197
Compare
…convention for dataset names '<sample name>_<era>' for MC and '<primary dataset>_<era> for data'
davidwalter2
force-pushed
the
260116_updBinning
branch
from
fe20c46 to
17db1fa
Compare
…; in dyturbo always set bins with qT<1GeV to 0
davidwalter2
force-pushed
the
260116_updBinning
branch
from
b3625c6 to
e6750b9
Compare
| $WREMNANTS_OUTDIR/WMass_eta_pt_charge_poiAsNoi/WMass_absEtaGen_ptGen_qGen_theoryfit/fitresults.hdf5 | ||
| --grouping max --config 'utilities/styles/styles.py' --postfix poiAsNoi | ||
| -o $WEB_DIR/$PLOT_DIR/unfolding_mw -n 50 --otherExtensions pdf png --showNumbers --oneSidedImpacts -s absimpact --scale 1.5 | ||
| -o $WEB_DIR/$PLOT_DIR/unfolding_mw -n 50 --otherExtensions pdf png --showNumbers --oneSidedImpacts -s absimpact --scaleImpacts 1.5 |
There was a problem hiding this comment.
I don't think you have to implement it for this PR, but it should be possible to take this from the pdfInfo to avoid it having to be manually synchronised.
There was a problem hiding this comment.
I think we want to keep the rabbit scripts analysis independent so I don't see how the pdfInfo can be used here. Maybe through the specified config file which. But I agree to do this at some later time.
| -o {args.outdir} --maxFiles -1 -j 300 --addHelicityAxis --pdf {pdf} --aggregateGroups Zmumu Wmunu | ||
| """ | ||
| print(f"Running command: {command}") | ||
| os.system(command) |
There was a problem hiding this comment.
os.system from a python script to call a python script is kind of criminal...
There was a problem hiding this comment.
First of all, I didn't add this script. But I find it useful. If the histmaker scripts were written with a main function etc. it could be possible to import and run ... I would leave this for future work.
There was a problem hiding this comment.
@kdlong, David speaks the truth: he bears no more guilt than you, it is I who is to be blamed for this terrible sin. Punish me as you see fit
| fig, ax = plt.subplots(figsize=(6, 6)) | ||
| icorrh.plot(ax=ax, cmin=0.5, cmax=1.5) | ||
|
|
||
| plot_name = f"corr2D_{generator}_MiNNLO_{proc}{suffix}" |
There was a problem hiding this comment.
Why are all these plots useful vs. just having one plot differential in Q?
There was a problem hiding this comment.
For debugging. There is a break statement at the end of the loop so it will only plot the first one, but it can be commented. This also fixes the case the minnloh hist has variations, which were previously summed up
scripts/corrections/corrs_by_helicity/make_pdf_from_corr_gen_hists.py
Outdated
Show resolved
Hide resolved
|
The PR is ready to be merged from my side, the CI also looks reasonable: |
3 participants
Harmonizing the dataset resources
Update on binning
Requires: https://gitlab.cern.ch/cms-wmass/wremnants-data/-/merge_requests/95